Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

use cmdtrl-enter to run a cell #5120

Merged
merged 1 commit into from
May 21, 2020
Merged

use cmdtrl-enter to run a cell #5120

merged 1 commit into from
May 21, 2020

Conversation

madhums
Copy link
Contributor

@madhums madhums commented Dec 17, 2019

Instead of ctrl-enter to run a cell, use cmdtrl-enter - this will provide better ux for mac users.

Instead of ctrl-enter to run a cell, use cmdtrl-enter - this will provide better ux for mac users.
Copy link
Member

@blink1073 blink1073 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Makes sense to me, thanks!

@blink1073 blink1073 added this to the 6.1 milestone May 21, 2020
@blink1073 blink1073 merged commit 4775ee5 into jupyter:master May 21, 2020
@rkohli3
Copy link

rkohli3 commented Oct 10, 2020

Why would this be changed after several years of using notebook. I was used to control+enter. I've been using notebook for several years and didn't have issues using control+enter. I don't understand how you could say it for everyone? I would have recommended this as a command mode entry, but since edit mode shortcuts can't be changed, it's an arbitrary decision to change this.

@kevin-bates
Copy link
Member

I suspect this side-effect wasn't intended at the time this PR was merged. As others are also having some issues with this change, I suggest we move the discussion to #5794 for how this can be best addressed. Thanks.

@rkohli3
Copy link

rkohli3 commented Oct 16, 2020

Thanks!! I hope it's addressed!

@madhums madhums deleted the patch-1 branch December 18, 2020 11:43
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jun 17, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants