Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Expose the default port of 8888 #521

Merged
merged 1 commit into from Oct 2, 2015
Merged

Expose the default port of 8888 #521

merged 1 commit into from Oct 2, 2015

Conversation

rgbkrk
Copy link
Member

@rgbkrk rgbkrk commented Oct 1, 2015

Seems like a reasonable default. We probably held back from doing this to not give people an unopinionated form of the original ipython/ipython image, but this is the raw notebook. With an EXPOSEd port, tmpnb can reason about it directly.

For Mr. @zischwartz

minrk added a commit that referenced this pull request Oct 2, 2015
@minrk minrk merged commit 82702b9 into master Oct 2, 2015
@minrk minrk deleted the rgbkrk-expose-8888 branch October 2, 2015 14:29
@minrk minrk added this to the 4.1 milestone Oct 2, 2015
@zischwartz
Copy link
Contributor

👍

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Apr 26, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants