Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Integrated LoginWidget into edit to enable users to logout from the t… #5406

merged 1 commit into from May 5, 2020


Copy link

…ext edit view. Issue #5399

Copy link

@kevin-bates kevin-bates left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These changes LGTM and the functionality appears sufficient. I'm hoping someone with some NB front-end experience and double-check the source changes in case there's something I don't know to look for. If no one swings by in the next couple days, I'll go ahead and merge.

Thank you @jpcastil!

Copy link
Contributor Author

jpcastil commented May 4, 2020

Hey @kevin-bates! Were you able to merge it? Thanks!

@kevin-bates kevin-bates merged commit ec5131c into jupyter:master May 5, 2020
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 25, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
None yet

Successfully merging this pull request may close these issues.

None yet

2 participants