Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add keyboard shortcuts to menu dropdowns #5525

Conversation

CadiChris
Copy link
Contributor

Following up on the work of @aaronmyatt in #2968, this PR fixes #2759.

Fix was all about adding a missing CSS rule regarding word wrapping specifically for kbd tag.

Windows fix OK

We (see below) tested the fix on many OS & browsers:

  • ✅ Mac OS: Safari & Firefox
  • ✅ Linux: Brave & Firefox
  • ✅ Windows 10: Edge & Chrome & Firefox

As a side note, this PR is a contribution from mob-programming involving : @CadiChris, @garaud, @klock, @limdhuul, @lmazardo, @mikaelletang, @murlock, @Nelyus, @pgrange

mob

@blink1073 blink1073 added this to the 6.2 milestone Jun 12, 2020
Copy link
Member

@blink1073 blink1073 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work, thanks! Since we've already got an RC out for 6.1 I'm leaving this open and targeted for 6.2.

@Nelyus Nelyus force-pushed the add-keyboard-shortcuts-to-menu-dropdowns branch from 0e17c45 to ab74efb Compare June 24, 2020 08:19
@lmazardo lmazardo force-pushed the add-keyboard-shortcuts-to-menu-dropdowns branch from ab74efb to 98f6464 Compare July 1, 2020 18:26
@kevin-bates kevin-bates mentioned this pull request Jul 22, 2020
24 tasks
@blink1073 blink1073 modified the milestones: 6.2, 6.1 Jul 23, 2020
@blink1073 blink1073 merged commit 7978c0f into jupyter:master Jul 23, 2020
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 23, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Improve keyboard shortcut discoverability
5 participants