Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

kill notebook its self when server cull idle kernel (new fix) #5593

Merged
merged 1 commit into from Jul 23, 2020
Merged

kill notebook its self when server cull idle kernel (new fix) #5593

merged 1 commit into from Jul 23, 2020

Conversation

levinxo
Copy link
Contributor

@levinxo levinxo commented Jul 9, 2020

Origin pull request: #5441
Sorry for you waiting a long time. I have fix ci error, pls review this new code diff, thx.

@kevin-bates kevin-bates mentioned this pull request Jul 9, 2020
24 tasks
@kevin-bates kevin-bates requested a review from Zsailer July 22, 2020 16:09
@kevin-bates
Copy link
Member

@Zsailer - since you reviewed the original PR that was superseded by this one, I'm hoping you can review this one as well. Thanks.

Copy link
Member

@Zsailer Zsailer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks great! Thanks for following through on this, @levinxo.

@Zsailer Zsailer merged commit 42227e9 into jupyter:master Jul 23, 2020
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 23, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants