Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert change in page alignment #5703

Merged
merged 1 commit into from Aug 28, 2020

Conversation

Zsailer
Copy link
Member

@Zsailer Zsailer commented Aug 27, 2020

This reverts #3173, which introduces some new alignment issues for browsers in on Arch Linux.

The new issues were slightly worse the original issue that #3173 tried to fix, so we're reverting it here.

@Zsailer
Copy link
Member Author

Zsailer commented Aug 27, 2020

Pinging @kevin-bates. Once this is merged, we should cut a patch release.

Copy link
Member

@kevin-bates kevin-bates left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good Zach - thank you. I've gone ahead and re-opened #3109 as well.

@Zsailer Zsailer merged commit 138b406 into jupyter:master Aug 28, 2020
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 23, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants