Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Gateway] Track only this server's kernels #5980

Merged
merged 1 commit into from
Apr 21, 2021

Conversation

kevin-bates
Copy link
Member

@kevin-bates kevin-bates commented Feb 9, 2021

While working on Enterprise Gateway, I found that if a gateway server is hosting kernels from multiple lab servers (via either jupyter_server or notebook), all kernels managed by the gateway server could be shut down when terminating one of the lab servers. This change ensures that kernel-based operations of a given lab/notebook server only operate against its own kernels.

Also:

  • Fixed some faulty log statements.
  • Found the KernelHandlers get method hadn't transitioned to a coroutine so I made that change.

Analogous changes have been made in jupyter-server/jupyter_server#407.

Copy link
Member

@blink1073 blink1073 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@kevin-bates kevin-bates merged commit a5ace13 into jupyter:master Apr 21, 2021
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Oct 19, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants