Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add square logo and desktop entry files #6010

Merged
merged 2 commits into from Mar 17, 2021

Conversation

befeleme
Copy link
Contributor

Hi!
Following the ancient discussion in #1922 I work on adding a desktop entry to Notebook when installed as RPM in Fedora.
I was looking for the icon to use an thought the official Jupyter logo would suit the best. The image, being rectangle more than square, got however unpleasantly distorted by the system. The graphics was resized so that it's 48x48px square with preserved original proportions and is easily scalable to any other square size.

If the files were included in Python package, they could be used by the other packagers as well. It'd be nice to have them coming from the upstream.

@befeleme befeleme marked this pull request as draft March 17, 2021 11:54
@befeleme
Copy link
Contributor Author

As was pointed out to me, environments displaying smaller icons (like Xfce) would benefit from icon without the text jupyter inside, so I add another file, favicon alike.
I propose to install the files using data_files which ensures the installation to given location. This works well both with system- and user-wide installation.
Looking forward to your opinion.

@befeleme befeleme marked this pull request as ready for review March 17, 2021 12:14
@blink1073 blink1073 added this to the 6.3 milestone Mar 17, 2021
Copy link
Member

@blink1073 blink1073 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very nice, thanks!

@blink1073 blink1073 merged commit 92a388c into jupyter:master Mar 17, 2021
@befeleme befeleme deleted the desktop-file branch March 18, 2021 07:30
@befeleme
Copy link
Contributor Author

@blink1073, just a quick question: when could the v. 6.3 be released? I'll help me adjust the next steps regarding the RPM package.

@blink1073
Copy link
Member

We plan to cut 6.3 early next week. I'm making a changelog entry PR today.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Sep 15, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants