Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix send2trash tests failing on Windows #6127

merged 1 commit into from Oct 28, 2021

Fix send2trash tests failing on Windows #6127

merged 1 commit into from Oct 28, 2021


Copy link

@dolfinus dolfinus commented Aug 9, 2021


I've faced an issue with failing tests on Windows:

This was caused by send2trash package issue while using it not in the main thread:

Not it is fixed, and tests have been passed successfully:

Let's upgrade the dependency.

Copy link
Contributor Author

Any updates here?

Copy link

@kevin-bates kevin-bates left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry for the delay @dolfinus - thank you for the ping!

@kevin-bates kevin-bates merged commit eb3a1c2 into jupyter:master Oct 28, 2021
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Apr 27, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
None yet

Successfully merging this pull request may close these issues.

None yet

2 participants