Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix send2trash tests failing on Windows #6127

Merged
merged 1 commit into from Oct 28, 2021
Merged

Fix send2trash tests failing on Windows #6127

merged 1 commit into from Oct 28, 2021

Conversation

dolfinus
Copy link
Contributor

@dolfinus dolfinus commented Aug 9, 2021

Hi.

I've faced an issue with failing tests on Windows:
https://github.com/jupyter/notebook/actions/runs/1104955127

This was caused by send2trash package issue while using it not in the main thread:
arsenetar/send2trash#59

Not it is fixed, and tests have been passed successfully:
https://github.com/dolfinus/notebook/actions/runs/1112095303

Let's upgrade the dependency.

@dolfinus
Copy link
Contributor Author

Any updates here?

Copy link
Member

@kevin-bates kevin-bates left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry for the delay @dolfinus - thank you for the ping!

@kevin-bates kevin-bates merged commit eb3a1c2 into jupyter:master Oct 28, 2021
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Apr 27, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants