Navigation Menu

Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable terminal tests as pywinpty is ported for python 3.9 #6228

Merged
merged 1 commit into from Nov 11, 2021

Conversation

niyas-sait
Copy link
Contributor

@niyas-sait niyas-sait commented Nov 11, 2021

This patch reverts a previous change that disabled terminal tests due to pywinpty issues with python 3.9. Pywinpty has been upgraded to support python 3.9 and all terminal tests are passing as expected.

Resolves #5967

Copy link
Member

@kevin-bates kevin-bates left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @nsait-linaro! The terminal tests are passing on 3.9 Windows and elsewhere.

@Zsailer Zsailer merged commit 20574f7 into jupyter:master Nov 11, 2021
@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 16, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Terminals on Windows/Python 3.9+ fail
4 participants