Enable terminal tests as pywinpty is ported for python 3.9#6228
Merged
Zsailer merged 1 commit intojupyter:masterfrom Nov 11, 2021
Merged
Enable terminal tests as pywinpty is ported for python 3.9#6228Zsailer merged 1 commit intojupyter:masterfrom
Zsailer merged 1 commit intojupyter:masterfrom
Conversation
kevin-bates
approved these changes
Nov 11, 2021
Member
kevin-bates
left a comment
kevin-bates
left a comment
There was a problem hiding this comment.
Thank you @nsait-linaro! The terminal tests are passing on 3.9 Windows and elsewhere.
Zsailer
approved these changes
Nov 11, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This patch reverts a previous change that disabled terminal tests due to pywinpty issues with python 3.9. Pywinpty has been upgraded to support python 3.9 and all terminal tests are passing as expected.
Resolves #5967