Skip to content

Docs parity for find with JupyterLab. - #6917

Merged
jtpio merged 5 commits into
jupyter:mainfrom
ericsnekbytes:find_docs_parity_jlab
Jun 21, 2023
Merged

jtpio merged 5 commits into
jupyter:mainfrom
ericsnekbytes:find_docs_parity_jlab

Conversation

@ericsnekbytes

@ericsnekbytes ericsnekbytes commented Jun 12, 2023 •

Copy link
Copy Markdown
Collaborator

This PR updates the find documentation to match changes in JupyterLab's. Questions that need to be answered:

  • Can users disable windowed rendering in Notebook the same way they can in Lab, as suggested by @krassowski for Lab?

Original PRs for reference:

@github-actions

Copy link
Copy Markdown
Contributor

Binder 👈 Launch a Binder on branch ericsnekbytes/notebook/find_docs_parity_jlab

Comment thread docs/source/notebook.md Outdated
ericsnekbytes and others added 2 commits June 12, 2023 15:26
Co-authored-by: Jeremy Tuloup <jeremy.tuloup@gmail.com>
@ericsnekbytes
ericsnekbytes marked this pull request as ready for review June 21, 2023 16:27
@ericsnekbytes

Copy link
Copy Markdown
Collaborator Author

@jtpio Can you approve this one (the related Lab PR has been merged now) then one of us can merge it?

@jtpio

jtpio commented Jun 21, 2023

Copy link
Copy Markdown
Member

Cool, thanks for working on this 👍

@jtpio jtpio added this to the 7.0 milestone Jun 21, 2023
@jtpio
jtpio merged commit 7c84112 into jupyter:main Jun 21, 2023
@github-actions github-actions Bot locked as resolved and limited conversation to collaborators Jun 21, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants