Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support pipfiles #174

Open
yuvipanda opened this issue Dec 20, 2017 · 21 comments

Comments

Projects
None yet
9 participants
@yuvipanda
Copy link
Collaborator

commented Dec 20, 2017

Moving from jupyterhub/binderhub#357

I think if we have a Pipfile, we should do the following:

  1. Use a virtualenv
  2. Ignore requirements.txt
  3. Install packages with Pipfile
@minrk

This comment has been minimized.

Copy link
Member

commented Dec 20, 2017

Agreed, except we can skip "use a virtualenv" since pipenv should cover that. It should also ignore runtime.txt, since pipenv covers installing Python itself with pyenv as well.

@choldgraf

This comment has been minimized.

Copy link
Collaborator

commented Dec 21, 2017

Does it seem reasonable to wait until we can pip install -p using pipfiles? Seems like whenever that functionality is there, it would be quite easy to support installing pipfiles almost the same way you'd do with requirements.txt.

@minrk

This comment has been minimized.

Copy link
Member

commented Jan 2, 2018

Does it seem reasonable to wait until we can pip install -p using pipfiles?

Yes, that would be reasonable. It depends on if we want to adopt the prototype implementation or wait for it to be solidified. One advantage of adopting the pipenv prototype is that it supports installing Python itself, which would solve the availability of Python 3.6.

@minrk

This comment has been minimized.

Copy link
Member

commented Jan 2, 2018

Another advantage of pipfiles is that it could deprecate runtime.txt, since it solves the Python-version problem for requirements.txt in a standard way, rather than a separate, custom file.

@choldgraf

This comment has been minimized.

Copy link
Collaborator

commented Jan 2, 2018

Seeing as how binder is in beta anyway, I'm +1 on adding pipfile support now so long as we don't think it'll be a pain to maintain

@choldgraf

This comment has been minimized.

Copy link
Collaborator

commented Feb 9, 2018

Just taking a look to see if pipfile has matured at all, and...

...is that project under active development? Assuming this is the repo, there hasn't been anything merged into master since late September, and it doesn't seem like the dev(s?) are responding to issues/PRs...

@yuvipanda

This comment has been minimized.

Copy link
Collaborator Author

commented Feb 10, 2018

@jezcope

This comment has been minimized.

Copy link

commented Feb 15, 2018

My understanding is that the Pipfile spec itself is now pretty stable and most of the active work is on pipenv as the reference implementation, as per @yuvipanda's link. I hadn't seen before but it looks like it's now being described as "the officially recommended Python packaging tool from Python.org".

@choldgraf

This comment has been minimized.

Copy link
Collaborator

commented Feb 15, 2018

that is great news! a lack of activity because everyone is in general agreement to the spec is much preferable to a lack of activity because the project is stale :-)

@jzf2101

This comment has been minimized.

Copy link
Collaborator

commented Sep 4, 2018

@choldgraf

This comment has been minimized.

Copy link
Collaborator

commented Sep 18, 2018

Is pipfile support a matter of "somebody just needs to make the PR" now? Or are we waiting for something to change in the pipfile spec etc? Just asking so we can clarify the issue w/ a path forward!

@yuvipanda

This comment has been minimized.

Copy link
Collaborator Author

commented Sep 19, 2018

@choldgraf yep, it's 'someone needs to make a PR'.

@jzf2101 jzf2101 added the help wanted label Sep 26, 2018

@trallard

This comment has been minimized.

Copy link
Contributor

commented Oct 15, 2018

Jumping on here 👋 it seems this is looking for someone to work on the issue and create a PR so I am volunteering myself to do this
Would this be ok @betatim @choldgraf ?

@choldgraf

This comment has been minimized.

Copy link
Collaborator

commented Oct 15, 2018

woooo go go go @trallard! :-)

@trallard trallard referenced this issue Oct 18, 2018

Merged

[MRG] Pipfile for repo2Docker #447

5 of 5 tasks complete

betatim referenced this issue Nov 12, 2018

trallard referenced this issue in trallard/repo2docker Nov 21, 2018

@Madhu94

This comment has been minimized.

Copy link

commented Dec 22, 2018

Is this ticket good to close ?

@betatim

This comment has been minimized.

Copy link
Collaborator

commented Dec 22, 2018

Not yet as #447 added a Pipfile to this repo but not pipfile support to repo2docker. Do you want to start working on this? Would be a cool addition!

@betatim

This comment has been minimized.

Copy link
Collaborator

commented Mar 2, 2019

@trallard do you have some (half done) code for this? After seeing https://twitter.com/palewire/status/1100786779848728576 I am keen/re-invigorated to get Pipenv support done :) Adding support for it would be a good way for me to learn what they are and how it works but if you have already done some work we should base it on that.

@trallard

This comment has been minimized.

Copy link
Contributor

commented Mar 4, 2019

Hey sorry this fell through the cracks 😑 I have some work done for this will push it ASAP

@choldgraf

This comment has been minimized.

Copy link
Collaborator

commented Mar 4, 2019

let us know how we can help @trallard !

@consideRatio

This comment has been minimized.

Copy link
Collaborator

commented Mar 17, 2019

+1 @trallard I consider this to be of massive value to BinderHub, I'd be happy to help!

@betatim

This comment has been minimized.

Copy link
Collaborator

commented Mar 18, 2019

@consideRatio if you want to get started on this I think it would be Ok to open a PR. I think @trallard is super busy so we can move ahead without waiting.

@consideRatio consideRatio self-assigned this Apr 19, 2019

@consideRatio consideRatio referenced a pull request that will close this issue Apr 20, 2019

Open

Support Pipfile / Pipfile.lock with pipenv #649

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.