[WIP] Update notebook to latest release #475
This PR does the following:
There are no more new conda-forge packages for Python 3.5 so we have to switch to using to normal pip packages if we need to upgrade something.
tornado was pinned because v5 was new at the time and there were some hiccups. Unpinning now so we don't get stuck in 4.x land.
Not dealt with in this PR: jinja2 contains syntax errors when you run it on Python3.5 (
Currently exporting an env that has packages in it that have been installed with
Apparently this is because something in conda broke when using pip 18.
Should we handcraft/fix the frozen environment? Wait for conda 45.6 that contains a fix? Other ideas?
@betatim are you referring to this message?
If so, that's .py->.pyc bytecompilation. It shouldn't be an issue because presumably the file isn't used on Python 3.5. If it's not imported, that error (which is logged but doesn't stop progress) doesn't matter.
Yes, I think now that Python 3.5 isn't building anymore, we should stop regenerating the frozen Python 3.5 environment. I've updated
In the future, I think we should probably not rely on conda to install things with pip, and instead do the whole thing in two stages:
That should be a lot more robust, I think.
At some point, old Python 3 is also going to go the way of Python 2, and be supported only for the kernel env.
That was my impression as well. I started looking into it mostly because it creates a lot of noise in the terminal that makes me ignore all the output which might contain errors that are actual errors. However I've made no progress on figuring out what the real fix is. Agreed that this seems to be harmless because it is unused.
Do you mean the Python developers are not changing Python 3.5 any more or there are no more releases of the notebook for Python 3.5?
I like the idea of deep freezing (is that what we are calling it?) certain Python versions like you did here.
There is nothing to fix. Python can bytecompile all the files in a package at install time, and happily moves on past any files it can't compile, noting which ones it couldn't. If these files aren't imported on Pythons where it can't be, then there's no issue.
I mainly mean relevant to us, that conda folks aren't building Python 3.5 packages anymore. Python 3.5 is no longer accepting bugfixes, but is accepting security fixes until 2020.