Join GitHub today
GitHub is home to over 40 million developers working together to host and review code, manage projects, and build software together.Sign up
Allow specifying images to reuse cache from #478
This lets us explicitly specify images that repo2docker
This isn't a problem on binder, since we don't pull images from
I like it! Two ponderings:
re: testing, will
We have discussed building and pushing images that contain the layers before copying in the repo contents for each build pack to docker hub. This would speed up the 100% shared part of the builds, for the user who has never built that buildpack before locally. If we do this then we could have a
There is also #310 for which this PR could be useful.
Yeah, that sounds like a good idea.
This already happens for images already built locally. --cache-from is only needed to re-use cache from images pulled from an external repository.
Since cache is used both for images already built locally and images pulled from a remote registry, there's no easy way to find out if this was effective or not.
This seems like a larger discussion that we should have in a separate issue.
This lets us explicitly specify images that repo2docker should try to re-use cached layers from. Docker normally only looks for layers from images that were *built* locally - if we want it to look in images that were *pulled* from a registry, we need to specify it here.
The way to test this would be:
Step (3) might drastically slow down other tests if run in the same place as them, so we gotta isolate this one.