Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Log a 'success' message when push is complete #482

Merged
merged 1 commit into from Dec 12, 2018

Conversation

@yuvipanda
Copy link
Collaborator

yuvipanda commented Dec 5, 2018

Otherwise there's no useful info printed on completion when
you are pushing from a local install.

@betatim

This comment has been minimized.

Copy link
Member

betatim commented Dec 6, 2018

Should we go down the route of mocking the docker client to test this bit?

I've used mock before, mostly via its patch() context manager but it never felt "right" (always needed several mocks mocking each others and :-/). Maybe someone with experience of using it could create a minimal example of how we'd do this?

@yuvipanda

This comment has been minimized.

Copy link
Collaborator Author

yuvipanda commented Dec 6, 2018

@betatim I don't think log messages need testing - or rather, I don't think repo2docker is at a testing place where adding tests for log messages is a useful use of our time.

@yuvipanda

This comment has been minimized.

Copy link
Collaborator Author

yuvipanda commented Dec 6, 2018

@betatim I'm sorry, I thought you meant mocking the log object to do testing.

I don't entirely understand reference to docker client in this PR. Can you expand a little bit on what you meant?

@yuvipanda

This comment has been minimized.

Copy link
Collaborator Author

yuvipanda commented Dec 6, 2018

Maybe meant for #478 (comment)? I think it's a great suggestion for that PR!

@yuvipanda yuvipanda requested review from betatim and choldgraf Dec 11, 2018
@betatim betatim merged commit 19d7c16 into jupyter:master Dec 12, 2018
4 checks passed
4 checks passed
ci/circleci: build_docs Your tests passed on CircleCI!
Details
codecov/patch 0% of diff hit (target 0%)
Details
codecov/project 76.32% (target 0%)
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.