Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set JULIA_DEPOT_PATH #555

Merged
merged 2 commits into from Jan 17, 2019

Conversation

@yuvipanda
Copy link
Collaborator

yuvipanda commented Jan 17, 2019

Equivalent of JULIA_PKGDIR for Julia 1.0+

Fixes #554

Equivalent of JULIA_PKGDIR for Julia 1.0+

Fixes #554
@yuvipanda

This comment has been minimized.

Copy link
Collaborator Author

yuvipanda commented Jan 17, 2019

Can verify that this works by locally running:

 docker run -it -p 9001:8888 -v $(pwd):/home/jovyan gcr.io/ucb-datahub-2018/math124-user-image:2ceecc4 

For testing, I think this should verify that the JULIA_DEPOT_PATH has at least some libraries installed.

@yuvipanda

This comment has been minimized.

Copy link
Collaborator Author

yuvipanda commented Jan 17, 2019

Test added!

@yuvipanda yuvipanda requested review from betatim and minrk Jan 17, 2019
@yuvipanda

This comment has been minimized.

Copy link
Collaborator Author

yuvipanda commented Jan 17, 2019

I neither increased nor decreased test coverage in any way codecov can tell... Not sure why it dings me.

Copy link
Member

fperez left a comment

Thanks @yuvipanda! These look good tome, for more on JULIA_DEPOT_PATH see this issue.

At some point it might be worth cleaning up the old pre-Julia-1.0 code, but I think that can be done later in case anyone wants to use this machinery with older Julia code...

@betatim betatim merged commit 5385b71 into jupyter:master Jan 17, 2019
5 checks passed
5 checks passed
ci/circleci: build_docs Your tests passed on CircleCI!
Details
ci/dockercloud Your tests passed in Docker Cloud
Details
codecov/patch Coverage not affected when comparing abe256d...3c9f31e
Details
codecov/project 86.73% remains the same compared to abe256d
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@betatim

This comment has been minimized.

Copy link
Member

betatim commented Jan 17, 2019

Nice work.

There are a few issues related to Julia support that we should address all in one go/with a coherent approach.

Currently we let users choose the version of Julia they want. We need to maintain "backwards compatibility" for the oldest version we let users select (and test it actually works :-/) -> removing code yes please, if we have some tests (or a Julia expert on hand to tell us what we are about to break :) ).

@fperez

This comment has been minimized.

Copy link
Member

fperez commented Jan 17, 2019

@StefanKarpinski, could we bug you for a sec here to make sure we're on the right track, or can you perhaps suggest someone else from the Julia team who could? We're trying to smooth the process for supporting Julia deployments on JHub - we'll likely be testing this in prod on campus (Cal) this spring term, but hopefully it will benefit others deploying elsewhere...

cc @stevengj

@StefanKarpinski

This comment has been minimized.

Copy link

StefanKarpinski commented Jan 17, 2019

They don't do the same thing exactly but I think that should work well enough.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants
You can’t perform that action at this time.