Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support requirements.txt & runtime.txt with Julia #557

Merged
merged 2 commits into from Jan 18, 2019

Conversation

@yuvipanda
Copy link
Collaborator

yuvipanda commented Jan 18, 2019

The comment about Julia only working with CondaBuildPack
hasn't been true since we switched to using conda for getting
our pythons. This change allows people to use requirements.txt
with Julia, rather than forcing them to use environment.yaml

The comment about Julia only working with CondaBuildPack
hasn't been true since we switched to using conda for getting
our pythons. This change allows people to use requirements.txt
with Julia, rather than forcing them to use environment.yaml
@yuvipanda yuvipanda requested review from betatim and minrk Jan 18, 2019
yuvipanda added a commit to yuvipanda/datahub that referenced this pull request Jan 18, 2019
@betatim

This comment has been minimized.

Copy link
Member

betatim commented Jan 18, 2019

Do we have to actually build an image to test this? The Julia tests are already some of the slowest we have so if we could test this in a --no-build way that would be awesome.

Can you help point me towards a bit more context or information about the build packs thing?

@yuvipanda

This comment has been minimized.

Copy link
Collaborator Author

yuvipanda commented Jan 18, 2019

@betatim When PythonBuildPack used to use a venv instead of conda, we ran into problems with Julia - #23 has more information. JuliaPy/PyCall.jl#411 was the primary underlying issue - Julia sortof pretends anyone using Python is primarily using Conda, and doesn't really support anything else well. And since PyPlot (used for plotting) depends on matplotlib, this was a no-go. So at that time, we made the Julia buildpack work only with Conda BuildPack.

Now we get conda for everything, so the restriction doesn't matter. The context for runtime.txt and requirements.txt is in PythonBuildPack, so we should get that here.

Re: tests, I think we have two PyPlot tests that do the same thing. I'm gonna remove one!

This is the equivalent to the pyplot-requirements test,
so just do one rather than 2.
@yuvipanda

This comment has been minimized.

Copy link
Collaborator Author

yuvipanda commented Jan 18, 2019

@betatim removed one test!

@betatim

This comment has been minimized.

Copy link
Member

betatim commented Jan 18, 2019

Nice. With that explanation and the tests I feel like the risk of us breaking something is tiny -> merge!

Should we make a new issue to see if we can add a test of using environment.yml with Julia without having to build things. Just to make sure we don't break it at a later time. Tim-more-faster-tests-is-better-Head

@yuvipanda

This comment has been minimized.

Copy link
Collaborator Author

yuvipanda commented Jan 18, 2019

@betatim thanks! Having an issue about being able to unit test 'does this directory tree make this kinda buildpack?' would be great.

@betatim betatim merged commit ba53102 into jupyter:master Jan 18, 2019
5 checks passed
5 checks passed
ci/circleci: build_docs Your tests passed on CircleCI!
Details
ci/dockercloud Your tests passed in Docker Cloud
Details
codecov/patch 100% of diff hit (target 20%)
Details
codecov/project Absolute coverage decreased by -0.09% but relative coverage increased by +13.26% compared to 5385b71
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.