Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

updating interfaces page and adding jupyterlab workspaces page #568

Merged
merged 3 commits into from Jan 30, 2019

Conversation

@choldgraf
Copy link
Collaborator

choldgraf commented Jan 29, 2019

This does the following:

  • updates the interfaces page to give more useful information.
  • Adds a section on Nteract and Shiny
  • Adds a page about packaging workspaces for JupyterLab
  • Does some minor re-structuring on the index page to make the content more discoverable (trying to riff off of @yuvipanda 's TLJH docs)

If we merge this in, then we should also update conf.py in the Binder docs repository to pull the JupyterLab workspaces page into the build: https://github.com/jupyterhub/binder/blob/master/doc/conf.py#L172

@choldgraf

This comment has been minimized.

Copy link
Collaborator Author

choldgraf commented Jan 29, 2019

cc also @lheagy who I believe said she was interested in helping out w/ documentation in binderland!

@lheagy
lheagy approved these changes Jan 29, 2019
Copy link
Collaborator

lheagy left a comment

Thanks for tagging me @choldgraf, this looks good - I just added a few minor comments.

docs/source/howto/lab_workspaces.rst Outdated Show resolved Hide resolved
It is similar to a more feature-filled version of the traditional
Jupyter Notebook interface.

Nteract comes pre-installed in any session that has been built from

This comment has been minimized.

Copy link
@lheagy

lheagy Jan 29, 2019

Collaborator

I think nteract is lower-case in most places in those docs - so might be better to use lower-case for consistency?

This comment has been minimized.

Copy link
@rgbkrk

rgbkrk Jan 30, 2019

Member

Yup, that's the case.

lheagy and others added 2 commits Jan 29, 2019
Co-Authored-By: choldgraf <choldgraf@gmail.com>
@choldgraf

This comment has been minimized.

Copy link
Collaborator Author

choldgraf commented Jan 29, 2019

cool - addressed your comments (maybe @rgbkrk can confirm that nteract should be all lower-case?)

@rgbkrk

This comment has been minimized.

Copy link
Member

rgbkrk commented Jan 30, 2019

Yeah, nteract is with a lower case n.

@choldgraf

This comment has been minimized.

Copy link
Collaborator Author

choldgraf commented Jan 30, 2019

Cool, then this PR is ready to go from my end. More docs prs to come in the future

@yuvipanda yuvipanda merged commit e3d82f8 into jupyter:master Jan 30, 2019
5 checks passed
5 checks passed
ci/circleci: build_docs Your tests passed on CircleCI!
Details
ci/dockercloud Your tests passed in Docker Cloud
Details
codecov/patch Coverage not affected when comparing ff894f4...112b718
Details
codecov/project 86.64% remains the same compared to ff894f4
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@yuvipanda

This comment has been minimized.

Copy link
Collaborator

yuvipanda commented Jan 30, 2019

Thanks, @choldgraf!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants
You can’t perform that action at this time.