Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

missing quotes in GIT_CREDENTIAL_ENV #572

Merged
merged 1 commit into from Jan 31, 2019

Conversation

@minrk
Copy link
Member

minrk commented Jan 31, 2019

echo without quotes removes newline, echo with quotes preserves it.

Previously failing test added.

I believe this is needed to deploy BinderHub with private credentials (cc @sgibson91 who's looking at this)

echo without quotes removes newline, echo with quotes preserves it.

Previously failing test added
@minrk minrk referenced this pull request Jan 31, 2019
@yuvipanda yuvipanda merged commit 9c2c7b6 into jupyter:master Jan 31, 2019
5 checks passed
5 checks passed
ci/circleci: build_docs Your tests passed on CircleCI!
Details
ci/dockercloud Your tests passed in Docker Cloud
Details
codecov/patch Coverage not affected when comparing 8f0fc91...a69145f
Details
codecov/project 86.64% remains the same compared to 8f0fc91
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.