Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

npm installation #573

Merged
merged 1 commit into from Feb 8, 2019

Conversation

@GladysNalvarte
Copy link
Contributor

GladysNalvarte commented Feb 7, 2019

  • defines NPM_DIR env and creates it at APP_BASE/npm
  • tells npm to use this dir for npm install --global

closes #307

Related to #25, but not closing since this doesn't introduce package.json support or similar.

@betatim

This comment has been minimized.

Copy link
Member

betatim commented Feb 7, 2019

Thanks for working on this. Looks good to me!

I'll leave it open for others to have a chance to offer opinions, going to merge tomorrow if no one else gets to it.

@minrk
minrk approved these changes Feb 8, 2019
@minrk

This comment has been minimized.

Copy link
Member

minrk commented Feb 8, 2019

Great, thanks @GladysNalvarte!

@betatim betatim merged commit e218a32 into jupyter:master Feb 8, 2019
5 checks passed
5 checks passed
ci/circleci: build_docs Your tests passed on CircleCI!
Details
ci/dockercloud Your tests passed in Docker Cloud
Details
codecov/patch 100% of diff hit (target 20%)
Details
codecov/project 86.7% (+0.06%) compared to 9c2c7b6
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@choldgraf

This comment has been minimized.

Copy link
Collaborator

choldgraf commented Feb 8, 2019

way to go @GladysNalvarte ! thanks! 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants
You can’t perform that action at this time.