Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pin conda during Python-switch step #576

Merged
merged 7 commits into from Feb 10, 2019

Conversation

@minrk
Copy link
Member

minrk commented Feb 8, 2019

even with auto-update-conda disabled, switching Python version (which reinstalls conda) can end up upgrading to the latest conda

Avoid this by adding the conda pinning to that install stage

This should fix the recent failures on CI, which appear to be due to a bug in the recent conda 4.6

minrk added 3 commits Feb 8, 2019
even with auto-update-conda disabled,
switching Python version (which reinstalls conda) can end up upgrading to the latest conda

Avoid this by adding the conda pinning to that install stage
conda uses the presence of this file as a magic indicator of conda envs
so make it empty, not gone
@betatim

This comment has been minimized.

Copy link
Member

betatim commented Feb 8, 2019

Is there repo we build in the CI where we can add a quick check that "conda is indeed the version we expect it to be'? It would have to be a test that has an environment.yml which asks for a different Python version correct?

this isn't linked to the version in the file, so will need to be updated in sync
@minrk

This comment has been minimized.

Copy link
Member Author

minrk commented Feb 8, 2019

Good call. Added a check to the Python 3.5 test

@minrk

This comment has been minimized.

Copy link
Member Author

minrk commented Feb 8, 2019

Will open a separate issue to track updating to conda 4.6, which is likely waiting for bugfix releases of 4.6

@betatim

This comment has been minimized.

Copy link
Member

betatim commented Feb 8, 2019

We could use the quant stack repo to test this I think by editing

verify: jupyter kernelspec list
to be verify: jupyter kernelspec list && conda --version | grep 4.5.12

@betatim

This comment has been minimized.

Copy link
Member

betatim commented Feb 8, 2019

A few of the builds are failing on:

/tmp/install-miniconda.bash: line 66: /srv/conda/envs/kernel/conda-meta/history: No such file or directory

I think. :-/

@betatim betatim referenced this pull request Feb 10, 2019
@betatim

This comment has been minimized.

Copy link
Member

betatim commented Feb 10, 2019

I made an edit to the path used on L66 of the install script. My guess is that the old path is the correct one and the new one (with extra envs/kernel in it) was a copy pasta from above. If not it seems like we should not have the same line in the if statement above and here but instead have it once.

betatim added 2 commits Feb 10, 2019
@betatim betatim merged commit 9766c95 into jupyter:master Feb 10, 2019
5 checks passed
5 checks passed
ci/circleci: build_docs Your tests passed on CircleCI!
Details
ci/dockercloud Your tests passed in Docker Cloud
Details
codecov/patch Coverage not affected when comparing 8597520...89027c6
Details
codecov/project 86.7% (+0.06%) compared to 8597520
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
fomightez added a commit to fomightez/BY4741_yscRNA-seq_suppl_data-binderized that referenced this pull request Feb 10, 2019
@minrk minrk deleted the minrk:pin-conda-more branch Mar 26, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.