Join GitHub today
GitHub is home to over 40 million developers working together to host and review code, manage projects, and build software together.Sign up
[MRG] Bump notebook package version #628
Travis fails because the new notebook gives an exit code of 137 when it gets killed. When we try to stop a container we first send a SIGTERM and then if that didn't work SIGKILL. The reason we see an exit code of 137 is because the notebook didn't shutdown properly on SIGTERM and the ngot killed by SIGKILL. Investigating what the proper fix is.
For some reason the notebook server doesn't exit when we send the SIGTERM signal to the container and as a result waiting for the container to shutdown leads to an exit code of 137 (the notebook server gets kill by SIGKILL).
I think it is weird and needs looking at but it isn't "dangerous". It seems if you do the equivalent sequence via
I'll merge now so we can deploy this on Sunday morning (now) as I think we should bump the build prefix which causes a lot of rebuilds and load -> would be good to start that at a quiet time of the week.