Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[MRG] Fix up the server proxy package to get websockets back #646

Merged
merged 1 commit into from Apr 15, 2019

Conversation

@betatim
Copy link
Member

betatim commented Apr 15, 2019

This uses an unreleased version of jupyter-server-proxy that has a fix for the broken websocket handling.

This (I think) will fix the problems reported in https://discourse.jupyter.org/t/debugging-your-binder/33/12?u=betatim

@meeseeksmachine

This comment has been minimized.

Copy link

meeseeksmachine commented Apr 15, 2019

This pull request has been mentioned on Jupyter Community Forum. There might be relevant details there:

https://discourse.jupyter.org/t/debugging-your-binder/33/13

@yuvipanda

This comment has been minimized.

Copy link
Collaborator

yuvipanda commented Apr 15, 2019

I don't mind merging this now and making a jupyter-server-proxy release later.

@betatim

This comment has been minimized.

Copy link
Member Author

betatim commented Apr 15, 2019

Now the question I always ask: Do you have an idea for a test that we can add to stop this from coming back? I don't really know anything about websockets other than they someone do "tricksy" things on the back of HTTP. Could we make a test based on https://github.com/binder-examples/minimal-dockerfile that starts a websocket server inside and connect to it from the outside? Would that be 20, 50 or 100 lines of code?

@yuvipanda yuvipanda merged commit 746e4d9 into jupyter:master Apr 15, 2019
5 checks passed
5 checks passed
ci/circleci: build_docs Your tests passed on CircleCI!
Details
ci/dockercloud Your tests passed in Docker Cloud
Details
codecov/patch Coverage not affected when comparing 0fb6797...bfa26bd
Details
codecov/project 90.72% remains the same compared to 0fb6797
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@betatim betatim deleted the betatim:fix-server-proxy branch Apr 16, 2019
betatim added a commit to binder-examples/r that referenced this pull request Apr 16, 2019
Part of the reason for doing this is to trigger a rebuild on mybinder.org after jupyter/repo2docker#646
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.