Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[MRG] Update issue templates #654

Merged
merged 2 commits into from Apr 28, 2019

Conversation

@betatim
Copy link
Member

betatim commented Apr 28, 2019

Add issue templates for the different kinds of questions people might have.

  • support questions are directed to discourse
  • bug reports ask for some details about the platform, versions, etc
  • feature requests contain a note that let people know that the best way to get a feature implemented is to "do it yourself". Where "do it yourself" doesn't mean "write the code" but more facilitate it by providing resources, etc. And that even then there are no promises that something will get merged because of the maintenance burden it adds.

This was sparked from a discussion with @KirstieJane about setting expectations for people opening issues.

@betatim betatim changed the title Update issue templates [MRG] Update issue templates Apr 28, 2019
Copy link
Collaborator

consideRatio left a comment

LGTM!

.github/ISSUE_TEMPLATE/bug_report.md Outdated Show resolved Hide resolved
A clear and concise description of what you want to happen.

**Describe alternatives you've considered**
A clear and concise description of any alternative solutions or features you've considered.

This comment has been minimized.

Copy link
@consideRatio

consideRatio Apr 28, 2019

Collaborator

Nice section!

@meeseeksmachine

This comment has been minimized.

Copy link

meeseeksmachine commented Apr 28, 2019

This pull request has been mentioned on Jupyter Community Forum. There might be relevant details there:

https://discourse.jupyter.org/t/a-proposal-for-jupyterhub-communications/505/19

Copy link
Collaborator

choldgraf left a comment

I think this would be great to try out! +1 the language looks good to me...

I wonder how folks think about making these a deafult set of templates for the jupyterhub repos https://help.github.com/en/articles/creating-a-default-community-health-file-for-your-organization#supported-file-types

@KirstieJane

This comment has been minimized.

Copy link
Contributor

KirstieJane commented Apr 28, 2019

Hey @betatim - I'm back home and just having a look at this.

I'm going to submit a PR to your PR because there are a couple of things that I think are just style preferences on my part, and others (updates to the contributing guidelines) that should maybe be in a different PR....

@betatim

This comment has been minimized.

Copy link
Member Author

betatim commented Apr 28, 2019

With two approving reviews, should we merge this? Then we can have #655 be a normal PR (instead of a PR to a PR) and keep things moving along.

@choldgraf

This comment has been minimized.

Copy link
Collaborator

choldgraf commented Apr 28, 2019

I think that @KirstieJane has good points to bring up... If they will require some community discussion, it'd probably be easier for folks to participate if we merged this and opened another PR to the repo... I'm happy to keep iterating w y'all on a new PR!

@KirstieJane

This comment has been minimized.

Copy link
Contributor

KirstieJane commented Apr 28, 2019

Ah - sorry I missed this folks. Fine to merge and for me to put in a new PR to master if you'd like.

@choldgraf

This comment has been minimized.

Copy link
Collaborator

choldgraf commented Apr 28, 2019

ok! I'm gonna merge this one, with the understanding that the language will probably require a little tweaking - I'd love to see what @KirstieJane puts together!

@choldgraf choldgraf merged commit 7681a6c into master Apr 28, 2019
6 checks passed
6 checks passed
ci/circleci: build_docs Your tests passed on CircleCI!
Details
ci/dockercloud Your tests passed in Docker Cloud
Details
codecov/patch Coverage not affected when comparing bc9554e...991a682
Details
codecov/project 90.72% remains the same compared to bc9554e
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details
@betatim betatim deleted the betatim-issue-templates branch Apr 29, 2019
@trallard trallard referenced this pull request May 6, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
5 participants
You can’t perform that action at this time.