Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[MRG] Drop support for Python 3.4 #684

Merged
merged 1 commit into from May 22, 2019

Conversation

@betatim
Copy link
Member

betatim commented May 21, 2019

This PR drops support for running repo2docker on a system that has Python 3.4 only. This does not effect users ability to build repositories that need Python 3.4

Why? One of our dependencies has stopped shipping wheels for Python 3.4 because https://www.python.org/dev/peps/pep-0429/ states that the last release of Python 3.4 was in March 2019.

There are two questions here:

@yuvipanda

This comment has been minimized.

Copy link
Collaborator

yuvipanda commented May 21, 2019

Most of our other projects require 3.5+ so am happy with this. I think we should give others an opportunity to object though. Not sure what our process for something like this should be

@yuvipanda

This comment has been minimized.

Copy link
Collaborator

yuvipanda commented May 21, 2019

Based on @minrk's comment in #521 (comment), I'm happy to drop 3.4 support.

@betatim betatim force-pushed the betatim:drop-python3.4 branch from e328688 to 1070a26 May 21, 2019
@betatim

This comment has been minimized.

Copy link
Member Author

betatim commented May 21, 2019

I tried to also switch us to testing on Python 3.7 by default (instead of 3.6) but apparently there is no Python 3.7 for Ubuntu 14.04, which is the base version we have in travis. Maybe that is a project for another day to move us forwards in time a bit there.

If the tests pass I'd be happy if this got merged. Let's see if anyone else has opinions.

It remains unclear to me why the Python 3.4 CI run didn't atempt to install things "from source" when there was no wheel.

@betatim betatim changed the title [WIP] Drop support for Python 3.4 [MRG] Drop support for Python 3.4 May 21, 2019
@betatim betatim force-pushed the betatim:drop-python3.4 branch from 1070a26 to 5303010 May 21, 2019
@yuvipanda

This comment has been minimized.

Copy link
Collaborator

yuvipanda commented May 21, 2019

Opened #685 to talk about switching base image in Travis to 16.04

@yuvipanda yuvipanda merged commit 368a640 into jupyter:master May 22, 2019
5 checks passed
5 checks passed
ci/circleci: build_docs Your tests passed on CircleCI!
Details
ci/dockercloud Your tests passed in Docker Cloud
Details
codecov/patch Coverage not affected when comparing 25ebca0...5303010
Details
codecov/project 90.97% remains the same compared to 25ebca0
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@yuvipanda

This comment has been minimized.

Copy link
Collaborator

yuvipanda commented May 22, 2019

As reference, Ubuntu 14.04 was EOL in April 2019, and shipped with Python 3.4. Python 3.5 was released in September 2015, almost 4 years ago.

I am going to merge this now, but we can always revert if needed.

@betatim betatim deleted the betatim:drop-python3.4 branch May 22, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.