Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[MRG] Zenodo content provider #693

Merged
merged 9 commits into from May 30, 2019

Conversation

@betatim
Copy link
Member

betatim commented May 27, 2019

The goal of this PR is to make repo2docker 10.5281/zenodo.3229823 work.

related: #234, #102

@betatim betatim force-pushed the betatim:zenodo-content branch from a8e6e04 to bb0687c May 28, 2019
@betatim betatim requested a review from yuvipanda May 28, 2019
@betatim betatim changed the title [WIP] Zenodo content provider [MRG] Zenodo content provider May 28, 2019
@betatim

This comment has been minimized.

Copy link
Member Author

betatim commented May 28, 2019

Before we merge this: needs documentation!

Copy link
Collaborator

yuvipanda left a comment

Minor quibbles, but this looks great! I think we should add at least a couple of integration tests, probably under 'external'

repo2docker/contentproviders/zenodo.py Show resolved Hide resolved
repo2docker/contentproviders/zenodo.py Outdated Show resolved Hide resolved
@yuvipanda

This comment has been minimized.

Copy link
Collaborator

yuvipanda commented May 29, 2019

@betatim this looks good to me. What do you think about adding an integration test in the externals list? I'd like that...

@betatim betatim force-pushed the betatim:zenodo-content branch 2 times, most recently from 19eae3c to 1c58a9a May 29, 2019
@betatim betatim force-pushed the betatim:zenodo-content branch from 1c58a9a to 71a7898 May 30, 2019
@betatim

This comment has been minimized.

Copy link
Member Author

betatim commented May 30, 2019

Added an external test and merged.

Code coverage went down a bit (hence the red tick) but most of the uncovered lines are in the copytree function taken from the stdlib.

@betatim betatim closed this May 30, 2019
@betatim betatim reopened this May 30, 2019
@betatim betatim merged commit 80fbc63 into jupyter:master May 30, 2019
3 of 5 checks passed
3 of 5 checks passed
codecov/project 90.16% (-0.84%) compared to 9c52e5a
Details
continuous-integration/travis-ci/pr The Travis CI build is in progress
Details
ci/circleci: build_docs Your tests passed on CircleCI!
Details
ci/dockercloud Your tests passed in Docker Cloud
Details
codecov/patch 81.25% of diff hit (target 20%)
Details
@betatim betatim deleted the betatim:zenodo-content branch May 30, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.