Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for julia 1.0.4 and 1.1.1 #710

Merged
merged 3 commits into from Jun 22, 2019

Conversation

@davidanthoff
Copy link
Contributor

davidanthoff commented Jun 20, 2019

No description provided.

@davidanthoff

This comment has been minimized.

Copy link
Contributor Author

davidanthoff commented Jun 20, 2019

I don't understand the build failure, and I'm not even sure it is related to the Julia stuff at all?

@tmorrell

This comment has been minimized.

Copy link
Contributor

tmorrell commented Jun 21, 2019

It's a new formatting check. If you install black using pip install black and type black . in the top level directory it should pass.

Copy link
Member

betatim left a comment

LGTM. Waiting for travis.

All hail our new formatting god ;)

@davidanthoff

This comment has been minimized.

Copy link
Contributor Author

davidanthoff commented Jun 21, 2019

All hail our new formatting god

It did insert a comma that was not there originally, that I then removed manually :) The comma was placed after the last element in the array, and hadn't been there in the original code.

@betatim

This comment has been minimized.

Copy link
Member

betatim commented Jun 21, 2019

Nods, for elements spread out over several lines there is a comma after every element. This isn't the case when all elements fit on a single line.

It seems a bit draconian at first but the fact that there are no choices left for us humans to make or config options to tweak means we get consistently formatted code and no bike shedding about what the "correct" formatting is.

@davidanthoff

This comment has been minimized.

Copy link
Contributor Author

davidanthoff commented Jun 21, 2019

Ah, so, I shouldn't have made that manual edit! Alright, next try :)

@betatim

This comment has been minimized.

Copy link
Member

betatim commented Jun 21, 2019

Correct. https://github.com/python/black has some more explanation on the choices made and why.

@betatim betatim merged commit 7019022 into jupyter:master Jun 22, 2019
5 checks passed
5 checks passed
ci/circleci: build_docs Your tests passed on CircleCI!
Details
ci/dockercloud Your tests passed in Docker Cloud
Details
codecov/patch 100% of diff hit (target 20%)
Details
codecov/project Absolute coverage decreased by -0.06% but relative coverage increased by +9.83% compared to 9f11058
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@davidanthoff davidanthoff deleted the davidanthoff:update-julia-versions branch Jun 22, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.