Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[MRG] Adding bash to Dockerfile to fix git-credential-env #738

Merged
merged 3 commits into from Jul 11, 2019

Conversation

@eexwhyzee
Copy link
Contributor

eexwhyzee commented Jul 10, 2019

Re: #736

Since alpine images don't include bash by default, this breaks the usage private repos with git-credential-env which requires bash.....small PR to just add bash to the Dockerfile (image size increased ~5MB)

eexwhyzee added 3 commits Jul 10, 2019
@eexwhyzee eexwhyzee changed the title [WIP] Adding bash to Dockerfile to fix git-credential-env [MRG] Adding bash to Dockerfile to fix git-credential-env Jul 10, 2019
@manics

This comment has been minimized.

Copy link
Contributor

manics commented Jul 10, 2019

Is bash necessary, or would changing https://github.com/jupyter/repo2docker/blob/master/docker/git-credential-env#L1 to /bin/sh also work?

@eexwhyzee

This comment has been minimized.

Copy link
Contributor Author

eexwhyzee commented Jul 10, 2019

@manics that was my initial thought at first too, but because of #389 I wanted to keep git-credential-env consistent by using bash

@betatim

This comment has been minimized.

Copy link
Member

betatim commented Jul 11, 2019

LGTM! Thanks again for the excellent bug report, tracking it down and fixing it. The open-source trifecta 🏆!

@betatim betatim merged commit fbe3503 into jupyter:master Jul 11, 2019
3 checks passed
3 checks passed
ci/circleci: build_docs Your tests passed on CircleCI!
Details
ci/dockercloud Your tests passed in Docker Cloud
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@eexwhyzee eexwhyzee deleted the eexwhyzee:add-bash-to-dockerfile branch Jul 11, 2019
@eexwhyzee

This comment has been minimized.

Copy link
Contributor Author

eexwhyzee commented Jul 11, 2019

@betatim no problem! glad i could contribute

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.