Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[MRG] Add Figshare content provider #788

Merged
merged 7 commits into from Sep 11, 2019

Conversation

@nuest
Copy link
Contributor

commented Sep 8, 2019

Also needs UI update: jupyterhub/binderhub#938

nuest added 2 commits Sep 8, 2019
add Figshare content provider
moving common functions to a DoiProvider

@nuest nuest force-pushed the nuest:contentproviders/figshare branch from cb0a46e to e6cd4b1 Sep 8, 2019

@betatim
betatim approved these changes Sep 8, 2019
Copy link
Member

left a comment

I left a few small comments, overall looks good to me!

@nuest

This comment has been minimized.

Copy link
Contributor Author

commented Sep 8, 2019

Thanks for taking a look so quickly! I will investigate the versioning.

@nuest nuest changed the title Add Figshare content provider [WIP] Add Figshare content provider Sep 8, 2019

@nuest

This comment has been minimized.

Copy link
Contributor Author

commented Sep 9, 2019

Merging this will affect two other open PRs (#739, #766). I'd like to help the authors with updating their code or can make the updates myself.

@nuest

This comment has been minimized.

Copy link
Contributor Author

commented Sep 9, 2019

@betatim Shall I will spend some time the code coverage~~?~~. I can surely improve the ones submitted now (figshare.py is far away from the targeted 80%).

@pdurbin

This comment has been minimized.

Copy link

commented Sep 9, 2019

Merging this will affect two other open PRs (#739, #766). I'd like to help the authors with updating their code or can make the updates myself.

Thank you, @nuest!! Any help getting those other pull requests merged is much appreciated!! 🎉

@nuest

This comment has been minimized.

Copy link
Contributor Author

commented Sep 11, 2019

@betatim I think this is ready now, can you take another look, please?

@betatim

This comment has been minimized.

Copy link
Member

commented Sep 11, 2019

Sure thing! We also change the title from WIP to MRG when it is ready for reviewing (and then maybe merge). MRG is a bit of a misnomer really it is more like "review please and then merge if you are happy" but yeah.

@nuest nuest changed the title [WIP] Add Figshare content provider [MRG] Add Figshare content provider Sep 11, 2019

@property
def content_id(self):
"""The Figshare article ID"""
return "{}.v{}".format(self.article_id, self.article_version)

This comment has been minimized.

Copy link
@betatim

betatim Sep 11, 2019

Member

🎉

@betatim betatim merged commit e33d5f8 into jupyter:master Sep 11, 2019

17 checks passed

ci/circleci: build_docs Your tests passed on CircleCI!
Details
ci/dockercloud Your tests passed in Docker Cloud
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
jupyter.repo2docker Build #20190911.2 succeeded
Details
jupyter.repo2docker (Job base) Job base succeeded
Details
jupyter.repo2docker (Job conda) Job conda succeeded
Details
jupyter.repo2docker (Job dockerfile) Job dockerfile succeeded
Details
jupyter.repo2docker (Job external) Job external succeeded
Details
jupyter.repo2docker (Job julia) Job julia succeeded
Details
jupyter.repo2docker (Job lint) Job lint succeeded
Details
jupyter.repo2docker (Job nix) Job nix succeeded
Details
jupyter.repo2docker (Job pipfile) Job pipfile succeeded
Details
jupyter.repo2docker (Job r) Job r succeeded
Details
jupyter.repo2docker (Job stencila_py) Job stencila_py succeeded
Details
jupyter.repo2docker (Job stencila_r) Job stencila_r succeeded
Details
jupyter.repo2docker (Job unit) Job unit succeeded
Details
jupyter.repo2docker (Job venv) Job venv succeeded
Details
@betatim

This comment has been minimized.

Copy link
Member

commented Sep 11, 2019

Merged! Could you make a PR that adds a line to the change log for this?

nuest added a commit to nuest/repo2docker that referenced this pull request Sep 12, 2019
@nuest nuest referenced this pull request Sep 12, 2019
@nuest

This comment has been minimized.

Copy link
Contributor Author

commented Sep 12, 2019

Sure (my bad), #792

Also: jupyterhub/binderhub#951

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.