Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP] r build-pack: when using ppa install r-recommended #830

Merged
merged 1 commit into from Jan 3, 2020

Conversation

@manics
Copy link
Contributor

manics commented Dec 30, 2019

jupyterhub/mybinder.org-deploy#1308 is reproducible when running manually:

root@abc76a08c669:/# apt-get install r-base=3.6.1-3bionic r-base-dev=3.6.1-3bionic libclang-dev
Reading package lists... Done
Building dependency tree
Reading state information... Done
Some packages could not be installed. This may mean that you have
requested an impossible situation or if you are using the unstable
distribution that some required packages have not yet been created
or been moved out of Incoming.
The following information may help to resolve the situation:

The following packages have unmet dependencies:
 r-base : Depends: r-recommended (= 3.6.1-3bionic) but 3.6.2-1bionic is to be installed
          Recommends: r-base-html but it is not going to be installed
E: Unable to correct problems, you have held broken packages.

Specifying a version for r-recommended=3.6.1-3bionic seems to fix it. Perhaps it's a packaging bug in the upstream 3.6.2 release?

I haven't tested other R versions, I won't have time to follow up on it over the next few day but feel free to take it over or push directly to this branch.

@choldgraf

This comment has been minimized.

Copy link
Collaborator

choldgraf commented Dec 30, 2019

This looks reasonable to me (though I agree it’s unclear what exactly is broken) and the tests are passing just fine. The one that is failing is the legacy dockerfile test. While I support the idea of “don’t merge until all tests pass no matter what”, I also think this would fix a pretty significant bug that is worth fixing on its own, so I am inclined to merge and deploy. Are there any objections?

@choldgraf

This comment has been minimized.

Copy link
Collaborator

choldgraf commented Dec 30, 2019

(For context, any r builds using the install.R build pack do not currently work due to dependency installation issues)

@choldgraf

This comment has been minimized.

Copy link
Collaborator

choldgraf commented Jan 3, 2020

I'm gonna merge this as I think it solves our immediate issue, and we can spot-check fixes as they need to happen. many thanks @manics for investigating

@choldgraf choldgraf merged commit 94d492e into jupyter:master Jan 3, 2020
17 of 18 checks passed
17 of 18 checks passed
continuous-integration/travis-ci/pr The Travis CI build failed
Details
ci/circleci: build_docs Your tests passed on CircleCI!
Details
ci/dockercloud Your tests passed in Docker Cloud
Details
default Workflow: default
Details
jupyter.repo2docker Build #20191230.1 succeeded
Details
jupyter.repo2docker (Job base) Job base succeeded
Details
jupyter.repo2docker (Job conda) Job conda succeeded
Details
jupyter.repo2docker (Job dockerfile) Job dockerfile succeeded
Details
jupyter.repo2docker (Job external) Job external succeeded
Details
jupyter.repo2docker (Job julia) Job julia succeeded
Details
jupyter.repo2docker (Job lint) Job lint succeeded
Details
jupyter.repo2docker (Job nix) Job nix succeeded
Details
jupyter.repo2docker (Job pipfile) Job pipfile succeeded
Details
jupyter.repo2docker (Job r) Job r succeeded
Details
jupyter.repo2docker (Job stencila_py) Job stencila_py succeeded
Details
jupyter.repo2docker (Job stencila_r) Job stencila_r succeeded
Details
jupyter.repo2docker (Job unit) Job unit succeeded
Details
jupyter.repo2docker (Job venv) Job venv succeeded
Details
@manics manics deleted the manics:r-recommended branch Jan 4, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.