Join GitHub today
GitHub is home to over 40 million developers working together to host and review code, manage projects, and build software together.Sign up
[WIP] r build-pack: when using ppa install r-recommended #830
jupyterhub/mybinder.org-deploy#1308 is reproducible when running manually:
Specifying a version for
I haven't tested other R versions, I won't have time to follow up on it over the next few day but feel free to take it over or push directly to this branch.
This looks reasonable to me (though I agree it’s unclear what exactly is broken) and the tests are passing just fine. The one that is failing is the legacy dockerfile test. While I support the idea of “don’t merge until all tests pass no matter what”, I also think this would fix a pretty significant bug that is worth fixing on its own, so I am inclined to merge and deploy. Are there any objections?