This repository has been archived by the owner on Jan 24, 2018. It is now read-only.
enable using tokens #257
Merged
enable using tokens #257
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Tested and works. |
|
Nice! You'll need to rebase since I merged the networks PR. |
rgbkrk
approved these changes
Jan 4, 2017
off by default, enable with:
--use_tokens=1
with tokens enabled, each user is redirected to a notebook server with a token,
making each server semi-private for the user who requests it.
|
@rgbkrk thanks, rebased and added the token to |
willingc
reviewed
Jan 4, 2017
| @@ -107,8 +110,12 @@ def create_notebook_server(self, base_path, container_name, container_config): | |||
| # | |||
| # Important piece here is the parametrized base_path to let the | |||
| # underlying process know where the proxy is routing it. | |||
| if container_config.use_tokens: | |||
There was a problem hiding this comment.
Perhaps add commit message text as a comment here:
use_tokens is off by default, enable with:
--use_tokens=1
with tokens enabled, each user is redirected to a notebook server with a token,
making each server semi-private for the user who requests it.
rgbkrk
approved these changes
Jan 4, 2017
|
Thanks! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
off by default, but with
--use_tokens=1, each user is assigned a token.closes #256