Skip to content

Commit

Permalink
Revert setup.py related changes from #1358
Browse files Browse the repository at this point in the history
  • Loading branch information
manics committed Sep 14, 2021
1 parent 034f58f commit 3cce063
Show file tree
Hide file tree
Showing 5 changed files with 1 addition and 16 deletions.
1 change: 0 additions & 1 deletion .dockerignore
@@ -1,3 +1,2 @@
helm-chart
!helm-chart/images
!helm-chart/binderhub/values.yaml
3 changes: 0 additions & 3 deletions .gitignore
Expand Up @@ -115,6 +115,3 @@ helm.txt
# Federation data page
doc/federation/data-federation.txt
.vscode/

# Autogenerated
binderhub/binderspawner_mixin.py
1 change: 0 additions & 1 deletion MANIFEST.in
Expand Up @@ -6,4 +6,3 @@ graft doc
include LICENSE
include versioneer.py
include binderhub/_version.py
include helm-chart/binderhub/values.yaml
3 changes: 1 addition & 2 deletions helm-chart/images/binderhub/Dockerfile
Expand Up @@ -24,8 +24,7 @@ WORKDIR /tmp/binderhub

# Build the binderhub python library into a wheel and save it to the ./dist
# folder. There are no pycurl wheels so we build our own in the build stage.
RUN pip install pyyaml && \
python setup.py bdist_wheel
RUN python setup.py bdist_wheel
RUN pip wheel pycurl --wheel-dir ./dist


Expand Down
9 changes: 0 additions & 9 deletions setup.py
Expand Up @@ -2,7 +2,6 @@

from setuptools import setup, find_packages
import subprocess
import yaml

import versioneer

Expand All @@ -28,14 +27,6 @@
subprocess.check_call(['npm', 'install'])
subprocess.check_call(['npm', 'run', 'webpack'])

# FIXME: See helm-chart/binderhub/values.yaml for a betterlong term fix
binderspawner_mixin_py = os.path.join(here, 'binderhub', 'binderspawner_mixin.py')
values_yaml = os.path.join(here, 'helm-chart', 'binderhub', 'values.yaml')
with open(values_yaml) as f:
values = yaml.safe_load(f)
with open(binderspawner_mixin_py, 'w') as f:
f.write(values['jupyterhub']['hub']['extraConfig']['0-binderspawnermixin'])

setup(
name='binderhub',
version=versioneer.get_version(),
Expand Down

0 comments on commit 3cce063

Please sign in to comment.