Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

updating sphinx theme #1008

Merged
merged 2 commits into from Nov 27, 2019
Merged

updating sphinx theme #1008

merged 2 commits into from Nov 27, 2019

Conversation

@choldgraf
Copy link
Member

choldgraf commented Nov 24, 2019

This updates our Sphinx theme to use the new pandas_sphinx_theme

No URLs will change (though some folders have been created in case we want to move files at some point). It also creates a new "community" section instead of lumping the lists of BinderHub deployments along with the "customization" section.

Here's what the new docs look like:

https://596-89419368-gh.circle-artifacts.com/0/html/index.html

@choldgraf choldgraf changed the title updating sphinx theme [WIP] updating sphinx theme Nov 24, 2019
@choldgraf choldgraf force-pushed the choldgraf:docs_theme branch from 8d5117a to ce28aee Nov 24, 2019
@choldgraf choldgraf changed the title [WIP] updating sphinx theme updating sphinx theme Nov 26, 2019
Copy link
Contributor

sgibson91 left a comment

LGTM!

@sgibson91 sgibson91 merged commit 2a7145f into jupyterhub:master Nov 27, 2019
4 checks passed
4 checks passed
ci/circleci: build_docs Your tests passed on CircleCI!
Details
codecov/patch Coverage not affected when comparing e0d720d...ede498d
Details
codecov/project 80.46% (target 0%)
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
yuvipanda pushed a commit to jupyterhub/helm-chart that referenced this pull request Nov 27, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.