Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

set HubOAuth.hub_host correctly #771

Merged
merged 1 commit into from Jan 21, 2019

Conversation

@bitnik
Copy link
Contributor

commented Jan 16, 2019

@minrk I just realized that I made a mistake in #770: I set JUPYTERHUB_HOST env variable with hub url, which also contains paths (such as base url). Here I removed that env var and set HubOAuth.hub_host in binderhub_config.py.

@minrk
minrk approved these changes Jan 16, 2019
@bitnik

This comment has been minimized.

Copy link
Contributor Author

commented Jan 17, 2019

@minrk could you restart the tests here?

@minrk minrk merged commit a529251 into jupyterhub:master Jan 21, 2019
4 checks passed
4 checks passed
ci/circleci: build_docs Your tests passed on CircleCI!
Details
codecov/patch Coverage not affected when comparing d4b724a...ae4e090
Details
codecov/project 79.37% (target 0%)
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
yuvipanda pushed a commit to jupyterhub/helm-chart that referenced this pull request Jan 21, 2019
@bitnik bitnik deleted the gesiscss:auth branch Jan 24, 2019
@choldgraf choldgraf added the bug label Oct 9, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.