Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make clear that it work with GitHub and GitLab #807

Open
wants to merge 1 commit into
base: master
from

Conversation

Projects
None yet
7 participants
@rgaiacs
Copy link

commented Mar 18, 2019

Improve on text and form.

Screenshot from 2019-03-18 14-55-10

The drop-down menu on the left should help users to know that GitLab and self-host are allow.

@betatim

This comment has been minimized.

Copy link
Member

commented Mar 18, 2019

I am not quite sure what you mean/want to change compared to what is already there.

Kapture 2019-03-18 at 16 20 23

The textbox label already changes depending on what you select from the dropdown menu.

We are thinking about a new tagline for BinderHub (https://discourse.jupyter.org/t/brainstorm-a-tag-line-for-binderhub/491/4) maybe we can also rework the text at the top of the page:

Screen Shot 2019-03-18 at 16 22 57

and mention gitlab and github explicitly? Right now it just says "Git repository" with github as the default in the dropdown menu. How to make it more obvious to the impatient reader is going to be tricky because we can't mention everything in the space above :-/ -> needs some wordsmithing I think.

@rgaiacs

This comment has been minimized.

Copy link
Author

commented Mar 19, 2019

I am not quite sure what you mean/want to change compared to what is already there.

When I read "GitHub repository" I will assume that it only works with GitHub (no GitLab, no Bitbucket, no self host, ...) This might be just me. But this is the reason that I sent the pull request to use the language "Git repository URL" that doesn't change when you select another provider.

The other change is to move the selector from right to left. I think this make clear that other host are available. But might be just me. I appreciate the words of some UX expert here.

I will comment about on the tagline on Discourse to keep the conversation in one place.

@choldgraf

This comment has been minimized.

Copy link
Member

commented Mar 19, 2019

My intuition is also that putting the button on the left will make it more discoverable (and thus easier to infer that multiple repository providers are supported). But I am also not a UI/UX expert :-)

That said, I think I'm +1 on moving it to the left haha

Re: keeping the text prompt static, perhaps we could try the button switch and see if that feels like it solves this challenge first?

@drj11

This comment has been minimized.

Copy link

commented Mar 19, 2019

I agree with @rgaiacs now that he has explained himself a bit :). There is no reason to "cleverly" change the text, make it static.

In the binder workshop in Manchester I do remember feeling vaguely annoyed that it was for github, and only my personal sense of outrage that someone should tie a service to github that led me to discover the switching dropdown.

@psychemedia

This comment has been minimized.

Copy link

commented May 6, 2019

When I read "GitHub repository" I will assume that it only works with GitHub (no GitLab, no Bitbucket, no self host, ...)

So does the Git repository allow you to run a repo from Bitbucket? (I couldn't figure out what Bitbucket patterned URL to use if so? eg on the repo: https://bitbucket.org/ueacomputervision/image-labelling-tool/src/master/ )

@betatim

This comment has been minimized.

Copy link
Member

commented May 6, 2019

The launch link is: https://mybinder.org/v2/git/https%3A%2F%2Fbitbucket.org%2Fueacomputervision%2Fimage-labelling-tool.git/f3ddb33e4839f8a0fe73c168993b405adc13daf0

and when you fill in the form it looks like this:

Screen Shot 2019-05-06 at 19 46 10

You need to explicitly specify the revision you want, you can't write master for the "arbitrary git URL" mode as we have no way to resolve that "word" into a revision, which is what we need to check the build cache. For GitHub and GitLab there is a little bit of magic to talk to the respective APIs to resolve it first. Could add this for bitbucket as well if someone is interested enough to open a PR.

@meeseeksmachine

This comment has been minimized.

Copy link

commented May 6, 2019

This pull request has been mentioned on Jupyter Community Forum. There might be relevant details there:

https://discourse.jupyter.org/t/how-to-use-bitbucket-repositories-on-mybinder-org/1000/1

@psychemedia

This comment has been minimized.

Copy link

commented May 6, 2019

@betatim ah, yep, thanks... doh! Should have added the revision, I think there were prompts to do so; not concentrating..!

My crude bookmarklet hack would be to scrape the URL from most recent commit on commits/all page....

@meeseeksmachine

This comment has been minimized.

Copy link

commented May 7, 2019

This pull request has been mentioned on Jupyter Community Forum. There might be relevant details there:

https://discourse.jupyter.org/t/how-to-use-bitbucket-repositories-on-mybinder-org/1000/1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.