Join GitHub today
GitHub is home to over 40 million developers working together to host and review code, manage projects, and build software together.Sign up
[WIP] Add support for 3+-part image names (like on GitLab) #986
This PR enables the use of "longer" image names such as
To allow both magical Docker Hub short names (like
Additionally, less than two or more than 255 characters are also refused as repository names.
To be able to test this with the existing Travis setup right away, I had to single the basename derivation out; alternatively we'd have to find a publicly reachable registry that supports 3+-part image names and is not GitLab, because getting a token from GitLab's registry doesn't work yet (see #965). Local testing with "long names" in a remote registry was fine, though.
This change breaks compatibility with registries that do not operate at their domain root (something like
Contributes to #965, but doesn't close it.
I think we should merge and take this for a test drive and see what happens.
One more thing: what should happen is someone puts in an image name/registry that violates the assumptions made in the name derivation function? Right now I'd say "stuff" happens aka undefined behaviour. Is it easy to raise a helpful error message or some such to help out the user?
Hm, I agree error handling is not done well in this PR. I'll reiterate that.
I found something else I overlooked before when looking for a way to generate useful error messages: We actually already know the registry's base address in
Closing this PR to rework it