Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

use a trie for matching URLs #8

Merged
merged 2 commits into from Sep 19, 2014
Merged

use a trie for matching URLs #8

merged 2 commits into from Sep 19, 2014

Conversation

@minrk
Copy link
Member

@minrk minrk commented Sep 19, 2014

avoid O(N) prefix matching

Using ab, I no longer see any performance penalty for up to a million routes.

With master, I saw an overhead of 100ms for 10k routes and ~800ms for 100k.

reissue of #7

@minrk minrk force-pushed the minrk:trie branch from 1e43714 to f2bf20d Sep 19, 2014
minrk added a commit that referenced this pull request Sep 19, 2014
use a trie for matching URLs
@minrk minrk merged commit 0f0a80c into jupyterhub:master Sep 19, 2014
1 check passed
1 check passed
@minrk
continuous-integration/travis-ci The Travis CI build passed
Details
@minrk minrk deleted the minrk:trie branch Sep 19, 2014
@minrk minrk mentioned this pull request Sep 19, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

1 participant