Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Switch CI to GitHub actions #407

Merged
merged 6 commits into from Feb 25, 2021
Merged

Switch CI to GitHub actions #407

merged 6 commits into from Feb 25, 2021

Conversation

minrk
Copy link
Member

@minrk minrk commented Feb 25, 2021 •
edited

  • remove travis CI
  • adopt pre-commit config from other projects, runs big auto-format commit
  • bump required Python to 3.6
  • bump required jupyterhub to 1.0
  • fix a small bug in a test

@minrk
Copy link
Member Author

minrk commented Feb 25, 2021

Since this PR adds the actions, they won't run until the PR is merged. Results can be seen on my fork, where everything is green.

@minrk minrk mentioned this pull request Feb 25, 2021
Closed
GeorgianaElena
GeorgianaElena approved these changes Feb 25, 2021
View reviewed changes
Copy link
Member

@GeorgianaElena GeorgianaElena left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

😍 This is awesome! Thank you @minrk!

consideRatio
consideRatio approved these changes Feb 25, 2021
View reviewed changes
Copy link
Member

@consideRatio consideRatio left a comment •
edited by minrk

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice this LGTM!

I suggest two non-critical changes:

  • Add workflow_dispatch: trigger, provides a UI button for maintainers to trigger a workflow.
  • Remove defaults.run.shell introduced by me misunderstanding what the default environment were - it is redundant to specify bash as I understand it now.

@minrk
address review in workflow
ec5c944 
- add workflow_dispatch trigger
- remove redundant shell: bash
- remove pip cache restore-keys
@minrk
Copy link
Member Author

minrk commented Feb 25, 2021

Thanks! Applied all your suggestions.

@consideRatio consideRatio merged commit 4c4ddc8 into jupyterhub:master Feb 25, 2021
@consideRatio
Copy link
Member

🎉 !!!

@minrk minrk deleted the gha branch February 25, 2021 14:39
@consideRatio
Copy link
Member

When we migrate we always forget the readme badge ;D

#408

@minrk minrk mentioned this pull request Feb 26, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@consideRatio consideRatio consideRatio approved these changes

@GeorgianaElena GeorgianaElena GeorgianaElena approved these changes

Assignees
No one assigned
Labels
documentation
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@minrk @consideRatio @GeorgianaElena