Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add test case for user with tilde #1983

Merged
merged 2 commits into from Jun 15, 2018
Merged

Conversation

willingc
Copy link
Contributor

@willingc willingc commented Jun 14, 2018

This adds a test case for the proxy and user in issue #1982.

@minrk
Copy link
Member

minrk commented Jun 15, 2018

Thanks for the test! I pushed an additional commit that should fix it. Then I think we're ready for 0.9.0.

Edit: saw the fix in #1984, removed mine from here. Then I think we should be set for 0.9.0.

@minrk
Copy link
Member

minrk commented Jun 15, 2018

Will release 0.9.0 as soon as Travis confirms that these tests now pass

@minrk minrk merged commit c495c47 into jupyterhub:master Jun 15, 2018
@minrk minrk deleted the test-tilde branch June 15, 2018 12:48
@minrk
Copy link
Member

minrk commented Jun 15, 2018

Tests passed! Thanks for the last minute test. Time to cut 0.9

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants