Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve contrast on muted text #4326

Merged
merged 1 commit into from Jan 31, 2023
Merged

Improve contrast on muted text #4326

merged 1 commit into from Jan 31, 2023

Conversation

bl-aire
Copy link
Contributor

@bl-aire bl-aire commented Jan 30, 2023

On accessing the pages with axe DevTools again, I found text that had a low contrast which I did not notice previously.

This PR increases the contrast of muted text on the Token page.

Before:

Screenshot 2023-01-30 at 13 18 17

After:

Screenshot 2023-01-30 at 12 16 18

@minrk

Copy link
Member

@minrk minrk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

Looks like a jupyterhub.sqlite file was accidentally committed. Can you remove it?

I think defining the variable is sufficient, without also using it again in the class. I linked above to where twitter bootstrap should already do this.

Can you also share before/after screenshots when changing CSS to show the changes?

@@ -70,3 +70,7 @@
border-color: @jupyter-orange;
outline-color: @jupyter-orange;
}

.text-muted {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this class required? I suspect that assigning the variable value does this already.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I commented it out and got the same result so I have removed it.

@minrk minrk changed the title A11y improve contrast on muted text Jan 30, 2023
@bl-aire
Copy link
Contributor Author

bl-aire commented Jan 30, 2023

Looks like a jupyterhub.sqlite file was accidentally committed. Can you remove it?

I was able to remove it using git rm.

I think defining the variable is sufficient, without also using it again in the class. I linked above to where twitter bootstrap should already do this.

I fixed this.

Can you also share before/after screenshots when changing CSS to show the changes?

I have added these to the PR.

@bl-aire bl-aire changed the title improve contrast on muted text Improve contrast on muted text Jan 31, 2023
@minrk
Copy link
Member

minrk commented Jan 31, 2023

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants