Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

log errors adding users already in db #689

Merged
merged 1 commit into from Aug 21, 2016
Merged

Conversation

@minrk
Copy link
Member

@minrk minrk commented Aug 15, 2016

avoids removal of system users preventing Hub startup

closes #687

try:
yield gen.maybe_future(self.authenticator.add_user(user))
except Exception:
# TODO: known cause of this is system users that have been removed.

This comment has been minimized.

@willingc

willingc Aug 15, 2016
Contributor

Perhaps a bit more clarity in the comment. Not sure if I have the details correct.

# TODO: Review approach to synchronize whitelist with db
# known cause of the exception is trying to add a user who has already been removed from the system
# but the user still exists in the hub's user db
avoids removal of system users preventing Hub startup
@minrk minrk force-pushed the minrk:log-add-user-error branch from f289789 to eda2164 Aug 21, 2016
@minrk minrk merged commit 21d25ac into jupyterhub:master Aug 21, 2016
4 checks passed
4 checks passed
ci/circleci Your tests passed on CircleCI!
Details
codecov/patch 100% of diff hit (target 0.00%)
Details
codecov/project 86.56% (target 0.00%)
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@minrk
Copy link
Member Author

@minrk minrk commented Aug 21, 2016

@willingc merged after updating the comment per your feedback. Thanks!

@minrk minrk modified the milestone: 0.7 Nov 11, 2016
@minrk minrk deleted the minrk:log-add-user-error branch Feb 23, 2018
chicocvenancio pushed a commit to chicocvenancio/jupyterhub that referenced this pull request May 6, 2018
log errors adding users already in db
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

2 participants