New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deprecate `--no-ssl` #789

Merged
merged 1 commit into from Sep 30, 2016

Conversation

Projects
None yet
2 participants
@minrk
Member

minrk commented Sep 30, 2016

it's unnecessarily pedantic. Just warn instead.

Deprecate `--no-ssl`
it's unnecessarily pedantic. Just warn instead.

@willingc willingc merged commit b6b2380 into jupyterhub:master Sep 30, 2016

2 checks passed

ci/circleci Your tests passed on CircleCI!
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@willingc

This comment has been minimized.

Contributor

willingc commented Sep 30, 2016

@minrk Looks good. I like the change. ☀️

I'm going to go ahead and merge.

@minrk minrk deleted the minrk:deprecate-no-ssl branch Oct 1, 2016

@minrk minrk modified the milestone: 0.7 Nov 11, 2016

chicocvenancio pushed a commit to chicocvenancio/jupyterhub that referenced this pull request May 6, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment