Navigation Menu

Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix the errors followed by the contributing steps #509

Merged
merged 3 commits into from Jun 4, 2021

Conversation

mggger
Copy link

@mggger mggger commented Jun 2, 2021

When following the contributing steps to run kubespawner, meets some errors.

This pr is to fix the errors I met

My python version is 3.7

@welcome
Copy link

welcome bot commented Jun 2, 2021

Thanks for submitting your first pull request! You are awesome! 🤗

If you haven't done so already, check out Jupyter's Code of Conduct. Also, please make sure you followed the pull request template, as this will help us review your contribution more quickly.
welcome
You can meet the other Jovyans by joining our Discourse forum. There is also a intro thread there where you can stop by and say Hi! 👋

Welcome to the Jupyter community! 🎉

@consideRatio consideRatio merged commit fd62c91 into jupyterhub:master Jun 4, 2021
@welcome
Copy link

welcome bot commented Jun 4, 2021

Congrats on your first merged pull request in this project! 🎉
congrats
Thank you for contributing, we are very proud of you! ❤️

@consideRatio
Copy link
Member

@mggger thank you for taking the time to contribute to this project!!! ❤️ 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants