Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[MRG] Replace hard-coded helm version with environment variable in deploy.py #1346

Merged
merged 6 commits into from Feb 18, 2020

Conversation

@sgibson91
Copy link
Contributor

sgibson91 commented Feb 13, 2020

This PR will replace the hard-coded helm version in deploy.py with an environment variable that can be set within .travis.yml. This will mean that when the helm version is bumped, it only needs to be updated in one place.

TODOS:

  • Update deploy.py to include a HELM_VERSION environment variable
  • Update .travis.yml to extract the helm version and parse to deploy.py
deploy.py Outdated Show resolved Hide resolved
@sgibson91 sgibson91 changed the title [WIP] Replace hard-coded helm version with environment variable in deploy.py [MRG] Replace hard-coded helm version with environment variable in deploy.py Feb 14, 2020
.travis.yml Outdated Show resolved Hide resolved
@minrk minrk merged commit 3606fe7 into master Feb 18, 2020
1 check passed
1 check passed
ci/circleci: build_docs Your tests passed on CircleCI!
Details
@sgibson91 sgibson91 deleted the update-deploy branch Feb 18, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants
You can’t perform that action at this time.