Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rework nbgitpuller link generator #76

Merged
merged 1 commit into from Mar 7, 2019

Conversation

Projects
None yet
1 participant
@yuvipanda
Copy link
Contributor

yuvipanda commented Mar 7, 2019

  • Easier way to select the file to open
  • Easier way to select the app to open
  • Better validation with more descriptive error messages
  • Split JS into its own file
  • Fully self hosted, so works offline with no internet
  • Bootstrap instead of PureCSS, to give better access to validation and
    layout features. Bootstrap is in use in large chunks of Jupyter.
    Plus, it lets me be lazy
  • Better visual layout of where the link is
Rework nbgitpuller link generator
- Easier way to select the file to open
- Easier way to select the app to open
- Better validation with more descriptive error messages
- Split JS into its own file
- Fully self hosted, so works offline with no internet
- Bootstrap instead of PureCSS, to give better access to validation and
  layout features. Bootstrap is in use in large chunks of Jupyter.
  Plus, it lets me be lazy
- Better visual layout of where the link is

@yuvipanda yuvipanda merged commit 30df8d5 into jupyterhub:master Mar 7, 2019

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.