New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding auth0 OAuthenticator implementation #54

Merged
merged 2 commits into from Nov 23, 2016

Conversation

Projects
None yet
2 participants
@namdets
Copy link

namdets commented Nov 22, 2016

Auth0 is a OAuth2 authentication aggregator service that supports mixing LDAP, SAML, OAuth2, etc. backing authentication providers.

We find it very useful.

You can test it by creating a free account here : https://auth0.com/opensource

@minrk
Copy link
Member

minrk left a comment

Thanks! I think the only thing I'd change is removing the custom logic for getting the client_id, etc. I'd like to avoid unnecessary inconsistency across the authenticators.

It's already true that these can be set in your config file:

c.Auth0OAuthenticator.client_id = 'xxx'
c.Auth0OAuthenticator.client_secret = 'yyy'
c.Auth0OAuthenticator.oauth_callback_url = '...'
"""
).tag(config=True)

def oauth_environment_variable_config(self):

This comment has been minimized.

@minrk

minrk Nov 22, 2016

Member

Can we skip this, and leave the getting of CLIENT_ID, etc. from the env the same as all the other implementations?

@namdets

This comment has been minimized.

Copy link

namdets commented Nov 22, 2016

Wow, Thanks for that!

So much cleaner!

@namdets

This comment has been minimized.

Copy link

namdets commented Nov 22, 2016

Hold on, there may now be a bug with the environment variable based config. Update incoming.

@namdets

This comment has been minimized.

Copy link

namdets commented Nov 22, 2016

OK, false alarm. I had a bug in my environment config, not the code.

I'm happy if you are.

@minrk minrk merged commit 500d0ce into jupyterhub:master Nov 23, 2016

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
@minrk

This comment has been minimized.

Copy link
Member

minrk commented Nov 23, 2016

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment