Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Record resolved reference in container image label #978

Open
betatim opened this issue Oct 22, 2020 · 0 comments
Open

Record resolved reference in container image label #978

betatim opened this issue Oct 22, 2020 · 0 comments

Comments

@betatim
Copy link
Member

betatim commented Oct 22, 2020

Bug description

If you run the following command (not explicitly providing a --ref):

repo2docker --no-build https://github.com/bokeh/bokeh-notebooks

will lead to the following labels being added to the container image:

LABEL repo2docker.ref="None"
LABEL repo2docker.repo="https://github.com/bokeh/bokeh-notebooks/"
LABEL repo2docker.version="0.11.0+179.g19c698e.dirty"

Expected behaviour

We should record the "resolved ref" instead of None. For Git based content providers this would be the SHA1 of the commit we are building.

This was noticed during #977 which has a quick back and forth on whether this behaviour is "as designed" or a bug. Conclusion was that this is a bug.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant