We read every piece of feedback, and take your input very seriously.
To see all available qualifiers, see our documentation.
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
If you run the following command (not explicitly providing a --ref):
--ref
repo2docker --no-build https://github.com/bokeh/bokeh-notebooks
will lead to the following labels being added to the container image:
LABEL repo2docker.ref="None" LABEL repo2docker.repo="https://github.com/bokeh/bokeh-notebooks/" LABEL repo2docker.version="0.11.0+179.g19c698e.dirty"
We should record the "resolved ref" instead of None. For Git based content providers this would be the SHA1 of the commit we are building.
None
This was noticed during #977 which has a quick back and forth on whether this behaviour is "as designed" or a bug. Conclusion was that this is a bug.
The text was updated successfully, but these errors were encountered:
No branches or pull requests
Bug description
If you run the following command (not explicitly providing a
--ref
):will lead to the following labels being added to the container image:
Expected behaviour
We should record the "resolved ref" instead of
None
. For Git based content providers this would be the SHA1 of the commit we are building.This was noticed during #977 which has a quick back and forth on whether this behaviour is "as designed" or a bug. Conclusion was that this is a bug.
The text was updated successfully, but these errors were encountered: