Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add nteract jupyter extension to requirements.txt based setups #200

Merged
merged 1 commit into from
Feb 1, 2018

Conversation

yuvipanda
Copy link
Collaborator

Didn't add to conda, since there is currently no way to add
pip packages to our conda frozen setup (due to
conda/conda#6438).

This means nteract will be available only when used with
requirement.txt, and not when used with environment.yml files.

@minrk
Copy link
Member

minrk commented Feb 1, 2018

It's actually our code that's preventing this due to being the simplest workaround for that conda bug, since we didn't have any pip dependencies at the time. I can fix it in a subsequent PR.

@minrk
Copy link
Member

minrk commented Feb 1, 2018

conflicts with the buildpack refactor

Didn't add to conda, since there is currently no way to add
pip packages to our conda frozen setup (due to
conda/conda#6438).

This means nteract will be available only when used with
requirement.txt, and not when used with environment.yml files.
@yuvipanda
Copy link
Collaborator Author

Rebased!

@minrk minrk merged commit e710416 into jupyterhub:master Feb 1, 2018
markmo pushed a commit to markmo/repo2docker that referenced this pull request Jan 22, 2021
Add nteract jupyter extension to requirements.txt based setups
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants