[MRG] Add caching of already built repositories #511
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
betatim
changed the title
betatim
force-pushed
the
cached-builds-take2
branch
from
41d61ae
to
e34d780
Compare
betatim
changed the title
|
Should we try again with this @yuvipanda? :) |
betatim
force-pushed
the
cached-builds-take2
branch
from
a471a5c
to
9bc0905
Compare
yuvipanda
reviewed
Dec 17, 2018
repo2docker/app.py
Outdated
| return True | ||
| return False | ||
|
|
||
| def _build_image(self, checkout_path): |
There was a problem hiding this comment.
I think this can be folded into the build function
There was a problem hiding this comment.
I liked the separation because build() does a bunch of things before&after building, and _build_image() just builds the image. :-/ It is an attempt to make the functions a bit shorter. Happy to move it.
There was a problem hiding this comment.
Private conversation with @yuvipanda just now: we put everything back in one method and he is happy with that.
Maybe look at splitting at a later point.
yuvipanda
requested changes
Dec 17, 2018
betatim
force-pushed
the
cached-builds-take2
branch
4 times, most recently
from
031ce51
to
35fc757
Compare
Add tests for image caching Adjust tests and main app for cached builds Remove obsolete command-line handling Remove print statement from test Fix subdirectory handling Put back exception instead of sys.exit()
betatim
force-pushed
the
cached-builds-take2
branch
from
35fc757
to
e7018d7
Compare
yuvipanda
approved these changes
Dec 22, 2018
markmo
pushed a commit
to markmo/repo2docker
that referenced
this pull request
Jan 22, 2021
[MRG] Add caching of already built repositories
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is a revival of #461