Adjusts whitespace for a code block in AWS instructions. #1237
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
betatim
reviewed
Apr 15, 2019
|
|
||
| #. Set the availability zones for the nodes | ||
|
|
||
| For this guide we will be allowing nodes to be deployed in all AZs:: | ||
|
|
||
| export ZONES=$(aws ec2 describe-availability-zones --region $REGION | grep ZoneName | awk '{print $2}' | tr -d '"') | ||
| export ZONES=$(echo $ZONES | tr -d " " | rev | cut -c 2- | rev) |
There was a problem hiding this comment.
Did you mean to delete this line?
There was a problem hiding this comment.
I think yes from looking at the screenshot you posted.
There was a problem hiding this comment.
Yes. Before this line was removed:
ubuntu@ip-172-31-94-142:~$ echo $ZONES
us-east-1aus-east-1bus-east-1cus-east-1dus-east-1eus-east-1
Without this line:
ubuntu@ip-172-31-94-142:~$ echo $ZONES
us-east-1a us-east-1b us-east-1c us-east-1d us-east-1e us-east-1f
|
LGTM thanks for your refinements @arokem! For reference, do you understand what problems were caused by the additional processing of the ZONES bash variable, and why we one no longer need to do such processing? |
consideRatio
approved these changes
Apr 16, 2019
|
@consideRatio : see #1237 (comment). That additional line seems to be there to remove white-space between the zone names, but I think we need that white-space. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Mostly removes a lot of extraneous whitespace. The only "substantial" change is here: